View source for Bugfixes/MediaWiki 1.41

==MW 1.41.0==
===Core===
;bugfix, resources/src/jquery.tablesorter/jquery.tablesorter.js 
:<small>(sort number in [[wde:Vorlage:Datum]] works as expected, see [[dif:2962272|2962272]])</small>
{| class="wikitable"
!search
!replace
|-
|
<syntaxhighlight lang="php" line start="790">
numeric: true
</syntaxhighlight>
|
<syntaxhighlight lang="php" line start="790">
numeric: false
</syntaxhighlight>
|}

===[[med:Extension:SyntaxHighlight|Extension:SyntaxHighlight]] (2.0)===

;bugfix, /pygments/pygmentize
:<small>(enables extension, see [https://www.mediawiki.org/w/index.php?title=Topic:Y8o4zjlnvtzpm9ry&topic_showPostId=y8oat4a6l14ava8x#flow-post-y8oat4a6l14ava8x MediaWiki])</small>

change file permissions from 644 to 744 (script needs to be executable by owner)

===[[med:Extension:SocialProfile|Extension:SocialProfile]] (1.14)===
;adjustment, /UserStats/includes/UserStats.php
:<small>(points start with 0; ideally this should be a configuration variable)</small>

{| class="wikitable"
!search
!replace
|-
|
<syntaxhighlight lang="php" line start="106">
			$stats['points'] = '1000';
</syntaxhighlight>
|
<syntaxhighlight lang="php" line start="106">
			$stats['points'] = '0';
</syntaxhighlight>
|}

===[[med:Extension:Quiz|Extension:Quiz]] (1.2.0)===
;Adjustment, /modules/ext.quiz.css
:<small>(correct/incorrect should not be colored green/red, because of [[wpen:Congenital red–green color blindness|Congenital red–green color blindness]]; ideally this should be a configuration variable)</small>
{| class="wikitable"
!search
!replace
|-
|<code>#14866d</code>
|<code>#0000ff</code>
|}

===[[med:Extension:Patroller|Extension:Patroller]] (2.1)===
;Adjustment, /includes/specials/SpecialPatroller.php
:<small>(in our wiki there are not many edits we have to patrol, so edits which were taken but not marked as patrolled should be available faster; ideally this should be a configuration variable)</small>

{| class="wikitable"
!search
!replace
|-
|
<syntaxhighlight lang="php" line start="53">
		if ( mt_rand( 0, 499 ) == 0 ) {
</syntaxhighlight>
|
<syntaxhighlight lang="php">
		if ( mt_rand( 0, 9 ) == 0 ) {
</syntaxhighlight>
|}

;Adjustment, /includes/specials/SpecialPatroller.php
:<small>(we do want to patrol all changes to one page, not only the last one; ideally this should be a configuration variable)</small>

{| class="wikitable"
!search
!replace
|-
|
<syntaxhighlight lang="php" line start="237">
		'rc_this_oldid = page_latest',
</syntaxhighlight>
|
|}

===[[med:Extension:VisualEditor|Extension:VisualEditor]] (0.1.2)===
;Bugfix, /includes/Hooks.php
:<small>(no more error because of a link to the diff of a new page, see [https://phabricator.wikimedia.org/T360631#9692278 phabricator])</small>

{| class="wikitable"
!search
!replace
|-
|
<syntaxhighlight lang="php" line start="230">
$parts['50_ve-init-mw-diffPage-diffMode'] = '<div class="ve-init-mw-diffPage-diffMode">' .
</syntaxhighlight>
|
<syntaxhighlight lang="php" line start="230">
		$output->addModuleStyles( [
			'ext.visualEditor.diffPage.init.styles',
			'oojs-ui.styles.icons-accessibility',
			'oojs-ui.styles.icons-editing-advanced'
		] );
		// T344596: Must load this module unconditionally. The TextSlotDiffRendererTablePrefix hook
		// below doesn't run when the diff is e.g. a log entry with no change to the content.
		$output->addModules( 'ext.visualEditor.diffPage.init' );
		$output->enableOOUI();
		$parts['50_ve-init-mw-diffPage-diffMode'] = '<div class="ve-init-mw-diffPage-diffMode">' .
</syntaxhighlight>
|}

===[[med:Extension:NamespaceRelations|Extension:NamespaceRelations]] (0.3.0)===
;Bugfix, NamespaceRelations.php
:<small>(corrects initialization of variable, see [https://www.mediawiki.org/wiki/Topic:X90b6q18ivyaxp6p MediaWiki])</small>
{| class="wikitable"
!search
!replace
|-
|
<syntaxhighlight lang="php" line start="118">
$namespaceInfo = MediaWikiServices::getInstance()->getNamespaceInfo();
</syntaxhighlight>
|move it to:
<syntaxhighlight lang="php" line start="103">
$namespaceInfo = MediaWikiServices::getInstance()->getNamespaceInfo();
if ( array_key_exists( $subjectNS, $this->namespacesToNamespace ) ) {
</syntaxhighlight>
|}

===[[med:Extension:MultiBoilerplate|Extension:MultiBoilerplate]] (2.2.0)===
;Feature by [[wde:Benutzer:Orci|Orci]], includes/Hooks.php:
:<small>(we only want content between pre and nowiki)</small>

{| class="wikitable"
!search
!replace
|-
|
<syntaxhighlight lang="php" line start="171">
	$editPage->textbox1 = $content;
</syntaxhighlight>
|
<syntaxhighlight lang="php" line start="171">
    $content = preg_replace( '#<pre>(.*?)</pre>#ims', '$1', $content );
    $content = preg_replace( '#<nowiki>(.*?)</nowiki>#ims', '$1', $content );
	$editPage->textbox1 = $content;
</syntaxhighlight>
|}

===[[med:Extension:MultiCategorySearch|Extension:MultiCategorySearch]]===
;Bugfixes by [[wde:Benutzer:StipenTreublatt|Stip]], MultiCategorySearch_body.php
:<small>(replaced deprecated functions)</small>

{| class="wikitable"
!search
!replace
|-
|
<syntaxhighlight lang="php">
list( $this->limit, $this->offset ) = $wgRequest->getLimitOffset( 100, 'searchlimit' );
</syntaxhighlight>
|
<syntaxhighlight lang="php">
list( $this->limit, $this->offset ) = $wgRequest->getLimitOffsetForUser( RequestContext::getMain()->getUser(), 100, 'searchlimit' );
</syntaxhighlight>
|-
|
<syntaxhighlight lang="php">
$dbr = wfGetDB( DB_SLAVE );
</syntaxhighlight>
|
<syntaxhighlight lang="php">
$dbr = wfGetDB( DB_REPLICA );
</syntaxhighlight>
|-
|(multiples)
<syntaxhighlight lang="php">
$dbr->numRows($res)
</syntaxhighlight>
|
<syntaxhighlight lang="php">
$res->numRows()
</syntaxhighlight>
|-
|(multiples)
<syntaxhighlight lang="php">
$dbr->fetchObject( $res )
</syntaxhighlight>
|
<syntaxhighlight lang="php">
$res->fetchObject()
</syntaxhighlight>
|-
|
<syntaxhighlight lang="php">
$catView->AddPage( $titleObj, $titleObj->mTextform, 10000 );
</syntaxhighlight>
|
<syntaxhighlight lang="php">
$catView->AddPage( $titleObj, $titleObj->getText(), 10000 );
</syntaxhighlight>
|-
|
<syntaxhighlight lang="php">
$dbr->freeResult( $res );
</syntaxhighlight>
|
<syntaxhighlight lang="php">
$res->free();
</syntaxhighlight>
|-
|(multiples)
<syntaxhighlight lang="php">
addWikiText
</syntaxhighlight>
|
<syntaxhighlight lang="php">
addWikiTextAsInterface
</syntaxhighlight>
|-
|
<syntaxhighlight lang="php">
$catView->formatList
</syntaxhighlight>
|
<syntaxhighlight lang="php">
$this->multcatList
</syntaxhighlight>
|-
|
<syntaxhighlight lang="php">
				$htresults .= '<p>' . wfShowingResults( $this->offset, $this->limit ) . "</p>\n";
				if( function_exists( 'wfViewPrevNext' ) ) {
					$jumpLinks = wfViewPrevNext(
						$this->offset, $this->limit, 'Special:MultiCategorySearch', $queryStr,
						($dbr->numRows($res) <= $this->offset + $this->limit) ? true : false );
				} else {
					$jumpLinks = $wgLang->viewPrevNext(
						$wgTitle, $this->offset, $this->limit, wfCgiToArray( $queryStr ),
						($dbr->numRows($res) <= $this->offset + $this->limit) ? true : false );
				}
</syntaxhighlight>
|
<syntaxhighlight lang="php">
				$jumpLinks = SpecialPage::buildPrevNextNavigation(
					$this->offset, $this->limit, wfCgiToArray( $queryStr ),
					($res->numRows() <= $this->offset + $this->limit) ? true : false );
</syntaxhighlight>
|-
|
|(add)
<syntaxhighlight lang="php">
// taken from core (CategoryViewer.php), because marked as private there
     function multcatList(
        $articles,
        $articles_start_char,
        $cssClasses = 'mw-category mw-category-columns'
    ) {
        $columns = array_combine( $articles, $articles_start_char );

        $ret = Html::openElement( 'div', [ 'class' => $cssClasses ] );

        $colContents = [];

        # Kind of like array_flip() here, but we keep duplicates in an
        # array instead of dropping them.
        foreach ( $columns as $article => $char ) {
            $colContents[$char][] = $article;
        }

        foreach ( $colContents as $char => $articles ) {
            # Change space to non-breaking space to keep headers aligned
            $h3char = $char === ' ' ? "\u{00A0}" : htmlspecialchars( $char );

            $ret .= Html::openElement( 'div', [ 'class' => 'mw-category-group' ] );
            $ret .= Html::rawElement( 'h3', [], $h3char ) . "\n";
            $ret .= Html::openElement( 'ul' );
            $ret .= implode(
                "\n",
                array_map(
                    static function ( $article ) {
                        return Html::rawElement( 'li', [], $article );
                    },
                    $articles
                )
            );
            $ret .= Html::closeElement( 'ul' ) . Html::closeElement( 'div' );

        }

        $ret .= Html::closeElement( 'div' );
        return $ret;
    }
</syntaxhighlight>
|}